zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Fix constraints warnings when rotating the device on iOS #802

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

This PR fixes constraints warnings that could occur when rotating the device when you have multiple components that need to invalidate their size.

codecov[bot] commented 6 years ago

Codecov Report

Merging #802 into master will increase coverage by 8.09%. The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
+ Coverage   77.22%   85.32%   +8.09%     
==========================================
  Files         152      152              
  Lines       10283    10404     +121     
==========================================
+ Hits         7941     8877     +936     
+ Misses       2342     1527     -815
Flag Coverage Δ
#ios 83.33% <56.25%> (+24.65%) :arrow_up:
#osx 86.56% <ø> (ø) :arrow_up:
#tvos 74.58% <30%> (-0.02%) :arrow_down:
Impacted Files Coverage Δ
Sources/iOS/Classes/SpotsScrollView.swift 70.66% <ø> (+2.66%) :arrow_up:
...es/iOS-Exclusive/Classes/SpotsScrollView+iOS.swift 100% <100%> (+7.84%) :arrow_up:
Sources/iOS/Classes/SpotsController.swift 65.82% <46.15%> (+10.98%) :arrow_up:
Sources/iOS/Classes/DefaultItemView.swift 80.64% <0%> (-6.46%) :arrow_down:
Sources/Shared/Extensions/Codable+Extensions.swift 57.77% <0%> (+2.22%) :arrow_up:
Sources/Shared/Structs/Registry.swift 73.07% <0%> (+3.84%) :arrow_up:
SpotsTests/Shared/Helpers.swift 46.22% <0%> (+4.71%) :arrow_up:
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aecf80a...8feb8ba. Read the comment docs.

zenangst commented 6 years ago

@vadymmarkov approves 😁