search

zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Refactor handleInfiniteScrolling to use new buffering algorithm #803

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

This refactoring makes use of the new buffering algorithm that was introduced on tvOS.

codecov[bot] commented 6 years ago

Codecov Report

Merging #803 into master will increase coverage by 7.22%. The diff coverage is 73.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
+ Coverage   77.22%   84.44%   +7.22%     
==========================================
  Files         152      152              
  Lines       10283    10428     +145     
==========================================
+ Hits         7941     8806     +865     
+ Misses       2342     1622     -720
Flag Coverage Δ
#ios 83.31% <73.07%> (+24.62%) :arrow_up:
#osx 86.56% <ø> (ø) :arrow_up:
#tvos 82.46% <73.07%> (+7.86%) :arrow_up:
Impacted Files Coverage Δ
Sources/iOS/Classes/Component.swift 90.33% <73.07%> (+19.52%) :arrow_up:
SpotsTests/tvOS/SpotsControllerTVOSTests.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/tvOS/SpotsScrollViewTVOSTests.swift 0% <0%> (-100%) :arrow_down:
...potsTests/Shared/ComponentFocusDelegateTests.swift 0% <0%> (-86.37%) :arrow_down:
Sources/iOS/Classes/DefaultItemView.swift 80.64% <0%> (-6.46%) :arrow_down:
...es/iOS-Exclusive/Classes/SpotsScrollView+iOS.swift 88.23% <0%> (-3.93%) :arrow_down:
SpotsTests/iOS/ComponentDelegateiOSTests.swift 81.01% <0%> (-3.8%) :arrow_down:
...urces/iOS/Extensions/Delegate+iOS+Extensions.swift 88.88% <0%> (-1.24%) :arrow_down:
Sources/Shared/Extensions/Codable+Extensions.swift 57.77% <0%> (+2.22%) :arrow_up:
Sources/iOS/Classes/SpotsScrollView.swift 70.66% <0%> (+2.66%) :arrow_up:
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aecf80a...793e6bf. Read the comment docs.