search

zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Feature auto alignment when using item pagination #805

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

If you combine infinite scrolling with item pagination, the component scroll view delegate will now correct the final content offset so that your view is centered inside your component.

codecov[bot] commented 6 years ago

Codecov Report

Merging #805 into master will decrease coverage by 16.43%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #805       +/-   ##
===========================================
- Coverage   77.13%   60.69%   -16.44%     
===========================================
  Files         152      151        -1     
  Lines       10317    10221       -96     
===========================================
- Hits         7958     6204     -1754     
- Misses       2359     4017     +1658
Flag Coverage Δ
#ios 58.14% <0%> (-0.2%) :arrow_down:
#osx 86.56% <ø> (ø) :arrow_up:
#tvos 57.52% <0%> (-16.98%) :arrow_down:
Impacted Files Coverage Δ
Sources/Shared/Classes/Delegate.swift 100% <ø> (ø) :arrow_up:
...ces/iOS/Extensions/Delegate+iOS+UIScrollView.swift 0% <0%> (ø) :arrow_up:
Sources/iOS/Classes/Component.swift 7.1% <0%> (-61.38%) :arrow_down:
SpotsTests/iOS/AnimationTests.swift 0% <0%> (-100%) :arrow_down:
Sources/iOS/Classes/ComponentCollectionView.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/iOS/InsetiOSTests.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/tvOS/SpotsControllerTVOSTests.swift 0% <0%> (-100%) :arrow_down:
Sources/iOS/Extensions/Inset+iOS.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/iOS/ListWrapperTests.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/iOS/ComponentCollectionViewTests.swift 0% <0%> (-100%) :arrow_down:
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 959cce8...0db70b7. Read the comment docs.