Closed zenangst closed 6 years ago
Merging #806 into master will increase coverage by
<.01%
. The diff coverage is86.2%
.
@@ Coverage Diff @@
## master #806 +/- ##
==========================================
+ Coverage 84.3% 84.31% +<.01%
==========================================
Files 152 152
Lines 10462 10486 +24
==========================================
+ Hits 8820 8841 +21
- Misses 1642 1645 +3
Flag | Coverage Δ | |
---|---|---|
#ios | 83.16% <86.2%> (-4.53%) |
:arrow_down: |
#osx | 86.59% <92.59%> (+0.03%) |
:arrow_up: |
#tvos | 82.31% <86.2%> (-4.48%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
Sources/Shared/Structs/Parser.swift | 83.78% <ø> (ø) |
:arrow_up: |
Sources/Shared/Structs/Configuration.swift | 85.71% <ø> (ø) |
:arrow_up: |
Sources/iOS/Classes/SpotsController.swift | 65.82% <ø> (ø) |
:arrow_up: |
...ces/iOS/Extensions/Delegate+iOS+UIScrollView.swift | 48.32% <0%> (ø) |
:arrow_up: |
...potsTests/Shared/SpotsControllerManagerTests.swift | 99.24% <100%> (+0.02%) |
:arrow_up: |
...ources/Shared/Classes/SpotsControllerManager.swift | 75.87% <83.33%> (+0.29%) |
:arrow_up: |
Sources/iOS/Classes/DefaultItemView.swift | 80.64% <0%> (-6.46%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e1aea2e...aee0ca1. Read the comment docs.
@onmyway133 @vadymmarkov mind taking a look now?
This PR improves the usage of reloading
SpotsController
's with component models. Now components are deemed useless if they don't have any content, this results in the component model being filter out before reloading happens.