search

zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Improves the scroll view algorithm #814

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

Adds a condition not to set the same frame twice. It also solves an observer recursion. The recursion could be triggered when scrolling in a horizontal component that was only partially on screen.

codecov[bot] commented 6 years ago

Codecov Report

Merging #814 into master will decrease coverage by 23.6%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #814       +/-   ##
===========================================
- Coverage   84.08%   60.47%   -23.61%     
===========================================
  Files         152      151        -1     
  Lines       10532    10296      -236     
===========================================
- Hits         8856     6227     -2629     
- Misses       1676     4069     +2393
Flag Coverage Δ
#ios 57.89% <0%> (-25.03%) :arrow_down:
#osx 86.67% <ø> (ø) :arrow_up:
#tvos 57.28% <0%> (-24.8%) :arrow_down:
Impacted Files Coverage Δ
...es/iOS-Exclusive/Classes/SpotsScrollView+iOS.swift 0% <0%> (-96%) :arrow_down:
SpotsTests/iOS/ListWrapperTests.swift 0% <0%> (-100%) :arrow_down:
...hared/Extensions/ItemConfigurable+Extensions.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/iOS/SpotsScrollViewTests.swift 0% <0%> (-100%) :arrow_down:
Sources/iOS/Classes/ComponentTableView.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/iOS/AnimationTests.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/iOS/ComponentTableViewTests.swift 0% <0%> (-100%) :arrow_down:
Sources/iOS/Extensions/Inset+iOS.swift 0% <0%> (-100%) :arrow_down:
...s/iOS/Extensions/UIViewController+Extensions.swift 0% <0%> (-100%) :arrow_down:
.../iOS/Extensions/CoreComponent+Extensions+iOS.swift 0% <0%> (-100%) :arrow_down:
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4c0760...958db7d. Read the comment docs.