search

zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Infinite scrolling: fix initial item position #818

Closed vadymmarkov closed 6 years ago

vadymmarkov commented 6 years ago

This PR fixes setting position for the initial item in collection view when infiniteScrolling flag is set to true.

codecov[bot] commented 6 years ago

Codecov Report

Merging #818 into master will increase coverage by 7.92%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #818      +/-   ##
==========================================
+ Coverage    76.1%   84.02%   +7.92%     
==========================================
  Files         152      152              
  Lines       10426    10538     +112     
==========================================
+ Hits         7935     8855     +920     
+ Misses       2491     1683     -808
Flag Coverage Δ
#ios 82.85% <100%> (+24.97%) :arrow_up:
#osx 86.67% <ø> (ø) :arrow_up:
#tvos 82.01% <100%> (+8.22%) :arrow_up:
Impacted Files Coverage Δ
Sources/iOS/Classes/Component.swift 90.31% <100%> (+26.56%) :arrow_up:
SpotsTests/tvOS/SpotsScrollViewTVOSTests.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/tvOS/SpotsControllerTVOSTests.swift 0% <0%> (-100%) :arrow_down:
...potsTests/Shared/ComponentFocusDelegateTests.swift 0% <0%> (-86.37%) :arrow_down:
Sources/iOS/Classes/DefaultItemView.swift 80.64% <0%> (-6.46%) :arrow_down:
SpotsTests/iOS/ComponentDelegateiOSTests.swift 81.01% <0%> (-3.8%) :arrow_down:
...urces/iOS/Extensions/Delegate+iOS+Extensions.swift 88.88% <0%> (-1.24%) :arrow_down:
Sources/Shared/Extensions/Codable+Extensions.swift 57.77% <0%> (+2.22%) :arrow_up:
Sources/Shared/Structs/Registry.swift 73.07% <0%> (+3.84%) :arrow_up:
SpotsTests/Shared/Helpers.swift 46.22% <0%> (+4.71%) :arrow_up:
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d659369...98f8db1. Read the comment docs.