zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Improve scrolling performance on tvOS #819

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

This applies the same kind of optimization that we have on iOS, it improves scrolling performance when using multiple components.

codecov[bot] commented 6 years ago

Codecov Report

Merging #819 into master will decrease coverage by 0.9%. The diff coverage is 54.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
- Coverage   84.81%   83.91%   -0.91%     
==========================================
  Files         152      152              
  Lines       10538    10548      +10     
==========================================
- Hits         8938     8851      -87     
- Misses       1600     1697      +97
Flag Coverage Δ
#ios 82.71% <54.16%> (-0.14%) :arrow_down:
#osx 86.67% <ø> (ø) :arrow_up:
#tvos 81.88% <54.16%> (+7.89%) :arrow_up:
Impacted Files Coverage Δ
Sources/Shared/Structs/Configuration.swift 85.71% <ø> (ø) :arrow_up:
Sources/iOS/Classes/SpotsController.swift 63.25% <0%> (-2.79%) :arrow_down:
Sources/iOS/Classes/ComponentFlowLayout.swift 68.05% <100%> (+2.55%) :arrow_up:
Sources/iOS/Classes/Component.swift 84.67% <80%> (-5.64%) :arrow_down:
SpotsTests/tvOS/SpotsScrollViewTVOSTests.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/tvOS/SpotsControllerTVOSTests.swift 0% <0%> (-100%) :arrow_down:
...potsTests/Shared/ComponentFocusDelegateTests.swift 0% <0%> (-86.37%) :arrow_down:
SpotsTests/iOS/ComponentDelegateiOSTests.swift 81.01% <0%> (-3.8%) :arrow_down:
...urces/iOS/Extensions/Delegate+iOS+Extensions.swift 88.88% <0%> (-1.24%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cd120e...9106d9a. Read the comment docs.

onmyway133 commented 6 years ago

@zenangst 👍