search

zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Remove fiddling with pan gesture recognizers #824

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

This follows up on "Fix the issue with component gesture recognisers while scrolling SpotsScrollView #822" - https://github.com/hyperoslo/Spots/pull/822/files

codecov[bot] commented 6 years ago

Codecov Report

Merging #824 into master will increase coverage by 7.93%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
+ Coverage    76.3%   84.24%   +7.93%     
==========================================
  Files         153      153              
  Lines       10434    10524      +90     
==========================================
+ Hits         7962     8866     +904     
+ Misses       2472     1658     -814
Flag Coverage Δ
#ios 83.1% <ø> (+25.28%) :arrow_up:
#osx 86.67% <ø> (ø) :arrow_up:
#tvos 82.26% <ø> (+8.16%) :arrow_up:
Impacted Files Coverage Δ
...ensions/SpotsController+UIScrollViewDelegate.swift 51.11% <ø> (+51.11%) :arrow_up:
...Extensions/Delegate+iOS+Extensions+Exclusive.swift 46.15% <ø> (+46.15%) :arrow_up:
SpotsTests/tvOS/SpotsScrollViewTVOSTests.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/tvOS/SpotsControllerTVOSTests.swift 0% <0%> (-100%) :arrow_down:
...potsTests/Shared/ComponentFocusDelegateTests.swift 0% <0%> (-86.37%) :arrow_down:
Sources/iOS/Classes/DefaultItemView.swift 80.64% <0%> (-6.46%) :arrow_down:
SpotsTests/iOS/ComponentDelegateiOSTests.swift 81.01% <0%> (-3.8%) :arrow_down:
...urces/iOS/Extensions/Delegate+iOS+Extensions.swift 88.88% <0%> (-1.24%) :arrow_down:
Sources/Shared/Extensions/Codable+Extensions.swift 57.77% <0%> (+2.22%) :arrow_up:
Sources/Shared/Structs/Registry.swift 73.07% <0%> (+3.84%) :arrow_up:
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7619dcb...06e8614. Read the comment docs.