search

zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Fix/setting initial x offset #826

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

This refactors the implementation to set the initial offset with better precision, instead of relying on the layout attributes from the collection view flow layout, we now rely on the cached frames that have been modified using layout attributes from the model.

codecov[bot] commented 6 years ago

Codecov Report

Merging #826 into master will increase coverage by <.01%. The diff coverage is 86.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
+ Coverage   83.97%   83.98%   +<.01%     
==========================================
  Files         153      153              
  Lines       10534    10553      +19     
==========================================
+ Hits         8846     8863      +17     
- Misses       1688     1690       +2
Flag Coverage Δ
#ios 82.8% <86.2%> (+0.01%) :arrow_up:
#osx 86.67% <ø> (ø) :arrow_up:
#tvos 81.96% <86.2%> (+0.01%) :arrow_up:
Impacted Files Coverage Δ
Sources/Shared/Classes/Delegate.swift 100% <ø> (ø) :arrow_up:
Sources/iOS/Classes/Component.swift 89.62% <86.2%> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b88998...fae039f. Read the comment docs.