search

zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Fix: tvOS infinity scrolling position #827

Closed vadymmarkov closed 6 years ago

vadymmarkov commented 6 years ago

You might not like it, but this PR basically uses old implementation of setupInfiniteScrolling method for tvOS, which doesn't have the problem with initial item not being focused. If you're working on some bigger refactoring, this could be a temporary solution I think. Could be rejected too, I don't mind 😄

codecov[bot] commented 6 years ago

Codecov Report

Merging #827 into master will decrease coverage by 0.02%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
- Coverage      84%   83.97%   -0.03%     
==========================================
  Files         153      154       +1     
  Lines       10553    10546       -7     
==========================================
- Hits         8865     8856       -9     
- Misses       1688     1690       +2
Flag Coverage Δ
#ios 82.79% <75%> (-4.53%) :arrow_down:
#osx 86.67% <ø> (ø) :arrow_up:
#tvos 81.95% <75%> (-4.49%) :arrow_down:
Impacted Files Coverage Δ
Sources/iOS/Classes/Component.swift 90.79% <ø> (+1.16%) :arrow_up:
Sources/iOS/Extensions/Component+iOS.swift 75% <75%> (ø)
Sources/iOS/Classes/DefaultItemView.swift 80.64% <0%> (-6.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d18c7dc...1b2d4e6. Read the comment docs.