search

zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Set new width to header and footer views when rotating #829

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

Fixes the issue with headers and footers not getting a new size when the controller rotates.

codecov[bot] commented 6 years ago

Codecov Report

Merging #829 into master will decrease coverage by 0.8%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #829      +/-   ##
==========================================
- Coverage   84.77%   83.97%   -0.81%     
==========================================
  Files         154      154              
  Lines       10509    10513       +4     
==========================================
- Hits         8909     8828      -81     
- Misses       1600     1685      +85
Flag Coverage Δ
#ios 82.78% <100%> (-4.53%) :arrow_down:
#osx 86.67% <ø> (ø) :arrow_up:
#tvos 81.94% <100%> (-0.97%) :arrow_down:
Impacted Files Coverage Δ
Sources/iOS+tvOS/Classes/SpotsController.swift 64.11% <100%> (+0.86%) :arrow_up:
SpotsTests/tvOS/SpotsControllerTVOSTests.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/tvOS/SpotsScrollViewTVOSTests.swift 0% <0%> (-100%) :arrow_down:
...potsTests/Shared/ComponentFocusDelegateTests.swift 0% <0%> (-86.37%) :arrow_down:
Sources/iOS+tvOS/Classes/DefaultItemView.swift 80.64% <0%> (-6.46%) :arrow_down:
SpotsTests/iOS/ComponentDelegateiOSTests.swift 81.01% <0%> (-3.8%) :arrow_down:
...tvOS/Extensions/Delegate+iOS+tvOS+Extensions.swift 88.88% <0%> (-1.24%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1ba7f4...b0de90c. Read the comment docs.