search

zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Improve/component flow layout on macos #830

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

This PR makes the same kind of change that we recently did to the ComponentFlowLayout on iOS and tvOS. https://github.com/hyperoslo/Spots/pull/828

codecov[bot] commented 6 years ago

Codecov Report

Merging #830 into master will decrease coverage by 0.83%. The diff coverage is 67.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
- Coverage   84.76%   83.92%   -0.84%     
==========================================
  Files         154      154              
  Lines       10513    10512       -1     
==========================================
- Hits         8911     8822      -89     
- Misses       1602     1690      +88
Flag Coverage Δ
#ios 82.78% <ø> (ø) :arrow_up:
#osx 86.6% <67.5%> (-0.08%) :arrow_down:
#tvos 81.94% <ø> (+8.1%) :arrow_up:
Impacted Files Coverage Δ
Sources/macOS/Classes/ComponentFlowLayout.swift 63.13% <67.5%> (-2.27%) :arrow_down:
SpotsTests/tvOS/SpotsControllerTVOSTests.swift 0% <0%> (-100%) :arrow_down:
SpotsTests/tvOS/SpotsScrollViewTVOSTests.swift 0% <0%> (-100%) :arrow_down:
...potsTests/Shared/ComponentFocusDelegateTests.swift 0% <0%> (-86.37%) :arrow_down:
SpotsTests/iOS/ComponentDelegateiOSTests.swift 81.01% <0%> (-3.8%) :arrow_down:
...tvOS/Extensions/Delegate+iOS+tvOS+Extensions.swift 88.88% <0%> (-1.24%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 871f594...8dffa8f. Read the comment docs.