search

zenangst / Spots

:bamboo: Spots is a cross-platform view controller framework for building component-based UIs
Other
1.31k stars 72 forks source link

Fix initial position when using infinite scrolling on tvOS #834

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

This fixes the initial content offset being set incorrectly when using inifinite scrollign on tvOS

codecov[bot] commented 6 years ago

Codecov Report

Merging #834 into master will increase coverage by 8.67%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
+ Coverage   76.01%   84.69%   +8.67%     
==========================================
  Files         154      154              
  Lines       10396    10512     +116     
==========================================
+ Hits         7903     8903    +1000     
+ Misses       2493     1609     -884
Flag Coverage Δ
#ios 82.76% <ø> (+24.4%) :arrow_up:
#osx 86.6% <ø> (ø) :arrow_up:
#tvos 74.05% <ø> (ø) :arrow_up:
Impacted Files Coverage Δ
Sources/iOS+tvOS/Classes/DefaultItemView.swift 80.64% <0%> (-6.46%) :arrow_down:
...rces/Universal/Extensions/Codable+Extensions.swift 57.77% <0%> (+2.22%) :arrow_up:
Sources/Universal/Structs/Registry.swift 73.07% <0%> (+3.84%) :arrow_up:
SpotsTests/Shared/Helpers.swift 46.22% <0%> (+4.71%) :arrow_up:
Sources/iOS+tvOS/Classes/SpotsContentView.swift 89.47% <0%> (+10.52%) :arrow_up:
Sources/Universal/Structs/Size.swift 88.88% <0%> (+11.11%) :arrow_up:
Sources/iOS+tvOS/Classes/ComponentFlowLayout.swift 59.62% <0%> (+12.73%) :arrow_up:
Sources/iOS+tvOS/Classes/SpotsController.swift 64.11% <0%> (+13.52%) :arrow_up:
...+tvOS/Extensions/Component+iOS+tvOS+Carousel.swift 90.9% <0%> (+22.72%) :arrow_up:
Sources/iOS+tvOS/Classes/Component.swift 90.59% <0%> (+24.78%) :arrow_up:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3731bab...ecb3ace. Read the comment docs.