search

zenangst / Vaccine

:syringe: Vaccine - Make your apps immune to recompile-disease
Other
307 stars 18 forks source link

Don't remove child views and views for navigation controllers #11

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

UINavigationController's should not remove its internals when they are injected as that could mean that the rootViewController will be removed.

codecov-io commented 6 years ago

Codecov Report

Merging #11 into master will increase coverage by 0.2%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #11     +/-   ##
=========================================
+ Coverage   74.93%   75.13%   +0.2%     
=========================================
  Files          14       14             
  Lines         363      366      +3     
=========================================
+ Hits          272      275      +3     
  Misses         91       91
Impacted Files Coverage Δ
Source/iOS+tvOS/UIViewController+Extensions.swift 67.92% <100%> (+1.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a86a4a2...220ae6d. Read the comment docs.