Markdown Treesitter Groups

[evantravers]

Finishes #63

[evantravers]

[mcchrish]

Any idea why there are some underlined words in the code blocks? It seems the spellchecker is activated in those areas.

EDIT: Looks like a limitation in nvim-treesitter: https://github.com/nvim-treesitter/nvim-treesitter/issues/698

[mcchrish]

I actually like how the non-treesitter handles links where the link text is underlined while the URI is highlighted with less contrast i.e. linked to Number.

With TS:

Without TS:

Is it possible to do this in TS? According to TS playground, there is no highlight group applied to the link text. We might need to patch this upstream.

[evantravers]

I agree whole heartedly, and am excited that your change to tree-sitter was approved so fast.

[evantravers]

I have not seen reference to these markdown treesitter groups like markdownTSLiteral… are you telling me to change my PR to something that exists or are you wishing something existed so that I could change my PR?

[mcchrish]

Tree-sitter creates specific versions of the groups per language and are linked to the general group. e.g. vimTSLiteral, javascriptTSLiteral, markdownTSLiteral and so on. This quite useful when we want to only target specific highlights of a language. You can see these groups when running :highlight.

My request is that we target these markdown specific groups instead. We have to create new groups for this. Example:

markdownTSLiteral { Delimiter };

[evantravers]

Thanks for the explanation… I was confused that there was literally no mention of markdownTSLiteral anywhere on github.

I'll make those changes and ping you again later this weekend.

[evantravers]

Ok… pulled out the original group additions/changes, made a markdown specific group, added to both files.

I don't love the revert (looks ugly in git history)… so when we approve the changes I'll squash and rebase before merge. Thoughts?

[mcchrish]

This looks great! One last thing I want to request is the link styling I mentioned here: https://github.com/mcchrish/zenbones.nvim/pull/64#issuecomment-996518952

[evantravers]

After changes.

[evantravers]

git reset --soft for a cleaned up commit. Same changes.

[mcchrish]

Thanks for the contribution! 🚀