zenbones-theme / zenbones.nvim

🪨 A collection of contrast-based Vim/Neovim colorschemes

MIT License

682 stars 48 forks source link

feat(windows terminal): supported #68

Closed brokenricefilms closed 2 years ago

brokenricefilms commented 2 years ago

67

i not sure how to get the theme name?

brokenricefilms commented 2 years ago

i running windows 11 with lua 5.4.2
i don't know what happen

mcchrish commented 2 years ago

Probably because extras/windowsTerminal does not exist. You have to create the directory.

Also, let's go with windows_terminal instead.

brokenricefilms commented 2 years ago

@mcchrish, Ready for review

brokenricefilms commented 2 years ago

@mcchrish i think it worked

mcchrish commented 2 years ago

Thanks!

mcchrish commented 2 years ago

@thuanpham2311 I think it would be great if the transformer is ported up to shipwright so other colorschemes can make use of it as well. https://github.com/rktjmp/shipwright.nvim/tree/master/lua/shipwright/transform/contrib What do you think?

brokenricefilms commented 2 years ago

@thuanpham2311 I think it would be great if the transformer is ported up to shipwright so other colorschemes can make use of it as well. https://github.com/rktjmp/shipwright.nvim/tree/master/lua/shipwright/transform/contrib What do you think?

It is great, i will create PR to shipwright

PR: https://github.com/rktjmp/shipwright.nvim/pull/5