zenbones-theme / zenbones.nvim

🪨 A collection of contrast-based Vim/Neovim colorschemes
MIT License
689 stars 48 forks source link

tmux support #8

Closed brokenricefilms closed 3 years ago

brokenricefilms commented 3 years ago

Issue: #7

Review

image image image image image

mcchrish commented 3 years ago

Hi @thuanpham2311 thanks for the PR! It looks great so far.

I guess I haven't documented this part well, but you have do make some extra steps to make the build script work. Please add the build script name into this line:

https://github.com/mcchrish/zenbones.nvim/blob/4c67a9e2a116cd4a693763d453a0fea7cc7a60ef/lua/zenbones/build.lua#L20

Then next is you have to run the build script by simply running make. Afterwards, just commit the generated tmux config.

brokenricefilms commented 3 years ago

uild script by simply running make. Afterwards, just commit the generated tmux config.

i'm a noob

image

mcchrish commented 3 years ago

That's strange. I can run the script properly and able to generate the tmux config.

What version of nvim are you using? Did you install lush.nvim?

brokenricefilms commented 3 years ago

That's strange. I can run the script properly and able to generate the tmux config.

What version of nvim are you using? Did you install lush.nvim?

I use NVIM v0.5.0 I just install lush.nvim but still don't work

image image

mcchrish commented 3 years ago

I see, can you temporarily remove the -u NORC option in the make file and try again?

brokenricefilms commented 3 years ago

I see, can you temporarily remove the -u NORC option in the make file and try again?

still not working

image

mcchrish commented 3 years ago

Try this, open nvim, then run the command :lua require("zenbones.build").build(). Make sure you are using your cloned copy:

Plug '~/path/to/your/cloned/zenbones.nvim'
brokenricefilms commented 3 years ago

Try this, open nvim, then run the command :lua require("zenbones.build").build(). Make sure you are using your cloned copy:

Plug '~/path/to/your/cloned/zenbones.nvim'

it worked :smile:

image

mcchrish commented 3 years ago

Great, I probably need to update the makefile to be more portable.

Let me know if it's ready for review.

brokenricefilms commented 3 years ago

i'm stupid