search

zencart / documentation

Zen Cart FAQs and Developer Documentation
https://docs.zen-cart.com
MIT License
7 stars 26 forks source link

Header navbar colours #1259

Open simon1066 opened 3 months ago

simon1066 commented 3 months ago

I didn't do a great job of colour-coordinating the /user and /dev navbar background colours in PR #1258. As it stands only some pages have the correct colour.

There are, I believe three types of pages -

I now know how to set the dev and user pages to the correct colour (by editing the relevent .html file in /layouts). The problem is codepage page types occur in both /user and /dev, so I don't believe it is possible to fully colour-coordinate all pages.

Two solutions:

  1. Abandon the idea of having different colour navbars and choose a single colour for all by redefining $primary.
  2. Have different colours for the user & dev page types and a third colour for codepage page types.

Something to think about.

scottcwilson commented 3 months ago

It looks good - let's leave it for now.

scottcwilson commented 3 months ago

To be clear: I would like to fix this issue at some point, but we have made a ton of changes in the last couple of weeks, it might be good to let it simmer for a bit.