zencart / documentation

Zen Cart FAQs and Developer Documentation
https://docs.zen-cart.com
MIT License
7 stars 27 forks source link

Coding Standards #879

Open torvista opened 2 years ago

torvista commented 2 years ago

https://docs.zen-cart.com/dev/contributing/coding_standards/ Should this not be beefed up to actually state what should be done as a routine cleanup when a file is touched for a "real" reason. Eg:

proseLA commented 2 years ago

at some point, we need to consider a standardized code fixer (not an IDE), ie something like:

https://github.com/FriendsOfPHP/PHP-CS-Fixer or https://styleci.io/ or https://github.com/squizlabs/PHP_CodeSniffer

create our own configuration using one of these tools, and then run the code through that prior to submitting a PR.

torvista commented 2 years ago

Fine by me, always keen to get more guidance on how to do things properly outside my bubble..