zencart / email-archive-manager

Plugin: Email Archive history viewer and manager
GNU General Public License v2.0
1 stars 2 forks source link

Search filter values are lost when you click a results row to see details #3

Closed neekfenwick closed 4 months ago

neekfenwick commented 4 months ago

Actual result:

Expected:

I know the code uses $_POST to read filter fields rather than $_GET and doesn't put the filter field values in the URL query parameters, so offhand I'm not sure how much of a rewrite would be required to fix this.

neekfenwick commented 4 months ago

While at it: the sidebox heading (white text on black) looks like it uses the wrong printf syntax or something, e.g. after clicking a row with query param "archive_id=3648930" I see "Archive #%d3648930 - 23/05/2024 09:28:03"

drbyte commented 4 months ago

Search filter values are lost when you click a results row to see details ... $_GET doesn't put the filter field values in the URL query parameters.

Hmmm ... I had converted a lot of $_GET stuff to $_POST to remove the clutter in the URL, and to avoid URL tampering.

Will take another look. Maybe use a $_SESSION var ... although that probably will then beg for a "reset search" button.