search

zencart / zencart

Zen Cart® is a full-function e-commerce application for your website.
https://github.com/zencart/zencart/releases
Other
375 stars 233 forks source link

OT coupon code tax error of excluded products #3612

Closed drbyte closed 8 months ago

drbyte commented 4 years ago

in includes/modules/order_total/ot_coupon.php the tax amount of an excluded product is removed twice from the total price resulting in unexpected amount showing as part of the order total.

approx line 620:

        if ($this->include_tax == 'true') {
         $orderTotal -= $productsTaxAmount;
        }
        if (DISPLAY_PRICE_WITH_TAX == 'true')
        {
          $orderTotal -= $productsTaxAmount;
        }

resolution appears to be changing if to include or or simply removing second if statement

Ref: https://www.zen-cart.com/showthread.php?226857-OT-coupon-code-tax-error-of-excluded-products

scottcwilson commented 1 year ago

1.5.8 line number is 646. Would you please PR?