search

zencart / zencart

Zen Cart® is a full-function e-commerce application for your website.
https://github.com/zencart/zencart/releases
Other
375 stars 233 forks source link

Ask a Question / Contact Us code duplication #6143

Open torvista opened 8 months ago

torvista commented 8 months ago

1) Should these not be page-specific?

https://github.com/zencart/zencart/blob/832a82036cb0a0b66bf6d59ae1687f93c199ed93/includes/templates/template_default/templates/tpl_ask_a_question_default.php#L41

https://github.com/zencart/zencart/blob/832a82036cb0a0b66bf6d59ae1687f93c199ed93/includes/templates/template_default/templates/tpl_contact_us_default.php#L45

2) Not relevant/required for Ask a Question?

https://github.com/zencart/zencart/blob/832a82036cb0a0b66bf6d59ae1687f93c199ed93/includes/templates/template_default/templates/tpl_ask_a_question_default.php#L48-L57

I supposed the contact form could be moved to a module for contact us, ask a question, back in stock...?

lat9 commented 8 months ago
  1. While those message-stack pages could be page-specific, I see no harm in the fact that the two pages share the same name.
  2. I can see a use-case where questions asked about a product might be associated with shipping vs. product behavior, with the question destination different.