search

zencoder / go-dash

A Go library for generating MPEG-DASH manifests.
Other
221 stars 61 forks source link

Proper GoModules #58

Closed makrusak closed 5 years ago

makrusak commented 5 years ago

Your GoModules support is not working now. Please add "v3" to go.mod following https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher. Also you should carefully replace import paths for your own packages. For example: https://github.com/zencoder/go-dash/blob/master/mpd/mpd.go In this file you import "github.com/zencoder/go-dash/helpers/ptrs", it should be replaced with "github.com/zencoder/go-dash/v3/helpers/ptrs". According to https://github.com/golang/go/wiki/Modules#automatic-migration-from-prior-dependency-managers Good luck :)

stuarthicks commented 5 years ago

Thanks for bringing this to our attention. While it does appear that the documentation recommends that approach, calling the current state "broken" is not useful as this works for other services that are using modules and this library.

Also, in the future, please either provide specific details on what is broken/not-working and raise it as an issue, or provide a complete PR with a fix. We can't finish this PR for you because we can't push commits to your fork. I will look at doing this change, but on a new branch/PR. Thanks.