zencoder / go-dash

A Go library for generating MPEG-DASH manifests.
Other
221 stars 61 forks source link

add support for EventStreams #72

Closed mjneil closed 4 years ago

mjneil commented 4 years ago

I opted to not add support for the xlink:href and xlink:actuate attributes for EventStream mainly because I was trying to do it in a clean way to support all elements that have the xlink attributes (Period,AdaptationSet,EventStream,SegmentList), using an embedded struct, but due to some issues with the way marshaling namespaced xml attributes works, I was trying to do something similar to the ContentProtectMarshal struct go-dash uses. However, since the xlink is not meant to be an element, but just attributes on the embedded struct, it wouldn't work quite the same. I decided it was better to tackle that problem separately rather than bundle it into this PR.