search

zencq / NomNom

NomNom is the most complete savegame editor for NMS but also shows additional information around the data you're about to change. You can also easily look up each item individually to examine its attributes, independently of a savegame, or get other useful information that are not related to a specific savegame (but enhanced if one is loaded).
https://zencq.github.io/NomNom/
GNU General Public License v3.0
440 stars 36 forks source link

[Bug] Application crashes without internet access #113

Closed LeeC2202Git closed 12 months ago

LeeC2202Git commented 1 year ago

Description

Application crashes when it has no internet access.

Reproduce

Steps to reproduce the behavior: Run the application with no internet access

Expected Behaviour

As there is no listed requirement for internet access, then I simply expected the application to run without error.

If there is a requirement for internet access, then several things need to be added to comply with privacy concerns. 1) A statement explicitly stating that internet access is required. 2) The reason that internet access is required. 3) Details about what information is collected and transmitted both in and out of the machine with regards to this internet connection. 4) An option to disable the internet requirement.

Additional Context

Add any other context about the problem here or at least complete the following information.

cengelha commented 1 year ago

I never experienced an issue w/o internet access but looks like the updater makes some trouble (despite it doesn't work atm). It's currently the only feature that requires internet access but shouldn't cause a crash... (there is a feature flag system as well tho, but that's not a real feature)

An overview about used online services and what data are send/received is already in the works and will be part of the wiki that will be published here on GitHub in the wiki section soon.

Giving you more control over the behavior of features requiring internet access is already on my list.

Pd69bq commented 1 year ago

experienced the same issue several times, and found similar entries in the crash report. does NomNom really needs to access api.github.com every time it starts? tbh, this "secretly" added requirement feels pretty bad.

Exception

Type

System.Net.Http.HttpRequestException

Message

A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (github.com:443)

cengelha commented 1 year ago

Hey, as I mentioned, it's the built-in update feature. It checks whether a new version is available at every start (and the required information and program files are hosted here on GitHub). This not different than in the goatfungus editor nor new or "secretly" added. It's like this since the 3rd alpha almost 3 years ago and mentioned in the changelog.

And as I also mentioned in the post before, all online services will soon be explained in detail in the upcoming wiki and giving you more control in NomNom itself is already on the todo list as well.

LeeC2202Git commented 1 year ago

I never experienced an issue w/o internet access but looks like the updater makes some trouble (despite it doesn't work atm). It's currently the only feature that requires internet access but shouldn't cause a crash... (there is a feature flag system as well tho, but that's not a real feature)

An overview about used online services and what data are send/received is already in the works and will be part of the wiki that will be published here on GitHub in the wiki section soon.

Giving you more control over the behavior of features requiring internet access is already on my list.

No problem. Out of habit, all downloaded exe files are blocked from the internet on my PC, it avoids me having to packet sniff to see what is happening in the communication chain. I also downloaded NMSCoordinates at the same time as this and that shows the same lack of internet connection in the onscreen log window but carries on running without error.

Most people don't run things without an internet connection so crashes like this are easily missed. Even though this might only be an update check, I prefer to have full control over that checking. As a developer with decades-worth of projects on my PCs, I don't leave anything to chance with unknown exe files and online communication.