search

zencq / NomNom

NomNom is the most complete savegame editor for NMS but also shows additional information around the data you're about to change. You can also easily look up each item individually to examine its attributes, independently of a savegame, or get other useful information that are not related to a specific savegame (but enhanced if one is loaded).
https://zencq.github.io/NomNom/
GNU General Public License v3.0
440 stars 36 forks source link

[Bug] Crash when trying to open Microsoft save #116

Closed frostworldgames closed 12 months ago

frostworldgames commented 1 year ago

Description

I get a "System.OutOfMemoryException" crash when trying to open the NMS Microsoft PC version save.

Reproduce

Steps to reproduce the behavior:

  1. Open Program, Autodetects Platform
  2. Click on 'Platform Save: Microsoft'

Expected Behavior

To open the save file to edit.

Files

NomNom 4.00.0.32-beta.2 Crash Report.pdf

Additional Context

YanezDiego commented 1 year ago

I am also experiencing this bug. Even after deleting and unzipping again (which might have not been the best decision) I am still receiving this issue.

twieland commented 1 year ago

Same here. I'm trying to convert an Xbox (GamePass) file to Steam, but it's already crashing when opening the file.

CameronJThomas commented 1 year ago

+1 for this issue. I don't even get a chance to click on the save before it crashes.

Exception of type 'System.OutOfMemoryException' was thrown.

at System.Text.Encoding.GetString(Byte[] bytes)
at System.Text.UTF8Encoding.UTF8EncodingSealed.GetString(Byte[] bytes)
at libNOM.io.Extensions.IEnumerableExtensions.GetString(IEnumerable`1 self)
at libNOM.io.Extensions.IEnumerableExtensions.GetJson(IEnumerable`1 self)
at libNOM.io.Platform.DeserializeContainer(Container container, Byte[] binary)
at libNOM.io.Platform.BuildContainer(Container container)
at libNOM.io.Platform.BuildContainer(Int32 metaIndex, Object extra)
at libNOM.io.PlatformMicrosoft.<>c__DisplayClass69_0.<BuildContainerCollection>b__0()
at System.Threading.Tasks.Task`1.InnerInvoke()
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
Brutestrength115 commented 1 year ago

I also have this issue

CameronJThomas commented 1 year ago

For anyone desperate, the original editor by goatfungus is up-to-date and working with the latest version. https://github.com/goatfungus/NMSSaveEditor

I just used it to transfer my Xbox save to Steam, albeit a little more manually than this tool (create new save in Steam version -> open Xbox save -> export JSON -> open Steam save -> import JSON -> save changes -> open Steam version again -> bob's your uncle).

Hopefully this one gets some TLC soon.

Brutestrength115 commented 1 year ago

Thank you @CameronJThomas

desolation0 commented 1 year ago

This was the behavior I experienced as well.

To add to this, if starting from fresh unpack and clicking the Microsoft install first my install of NomNom was then unable to initialize. It would close out after launch before any UI elements were loaded. Needed to delete portable.config to reset the settings. Trying again would once again crash out and require deleting the config file before rebooting.

Windows 10 if that information helps.

Uploading the report as html didn't function, so converted it to .txt extension, sorry for any inconvenience. report.20230302181944 - Copy.txt