search

zend-patterns / ZendServerPuppet

ZendServerPuppet
Apache License 2.0
6 stars 16 forks source link

Added conditional check for manage_repos so that we don't have a depe… #61

Closed bschonec closed 7 years ago

bschonec commented 7 years ago

…ndency when we don't need one.

There's no need to have dependencies on the yum repo if you're not managing the repositories.

This is useful if you have a satellite or spacewalk server and your linux machines are subscribed to the channel that houses the Zend RPMs.

ubellavance commented 7 years ago

You should simply add an else statement with only the Package line. I think that should work.

bschonec commented 7 years ago

Ahhh, yes. I see my mistake there.

ubellavance commented 7 years ago

Do you think you'll have time to do it? I may have time to do it tonight, I'm not sure. If you do it, please make sure you test it before submitting the PR.

bschonec commented 7 years ago

I have no idea how to write tests....It looks like a simple update. If you can handle it, it'd be much better that way. I have a disaster recovery exercise to start tomorrow morning.

On Wed, Jul 5, 2017 at 5:50 PM, Ugo Bellavance notifications@github.com wrote:

Do you think you'll have time to do it? I may have time to do it tonight, I'm not sure. If you do it, please make sure you test it before submitting the PR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zend-patterns/ZendServerPuppet/pull/61#issuecomment-313236971, or mute the thread https://github.com/notifications/unsubscribe-auth/AJIHfkkWXCI55qrDk1YaE9R0vdb3V6eJks5sLAU3gaJpZM4OOpxe .

ubellavance commented 7 years ago

I didn't really mean to write tests, but at least to test the change in a VM. Test a simple install with the module with manage_repos on, and with manage_repos off.

I'll take care of it, don't worry, you can concentrate on your DR exercise.

ubellavance commented 7 years ago

I had a second look at it and the actual package install is in install.pp. I'm not good enough in Puppet to know what's done exactly in install/redhat.pp I'll try to test your edit when I have time.