search

zend-patterns / ZendServerSDK

Pure ZF2 CLI for zpk creation and webapi client.
BSD 3-Clause "New" or "Revised" License
22 stars 17 forks source link

Give vhost related commands option to read template from file #47

Closed maxbeutel closed 9 years ago

maxbeutel commented 9 years ago

We dynamically create vhosts via zs-client in an ant task. Passing the vhost template escaped as a commandline argument was just not possible.

I built in a check that if the --template parameter resolves to a file path, then the content of the file i read in php. Usage: zs-client ... --template=/path/to/vhost.config

This change should be BC.

Do I have to re-generate the phar and add it to this pull request?

maxbeutel commented 9 years ago

Ping – can I get some feedback on this PR? We really would like to get this change upstream. :-)

clarkphp commented 9 years ago

Pong = Hi Max; as soon as someone gets a chance to look at it, we will let you know. Looks like a good idea. Clark

On Thu, Nov 20, 2014 at 5:49 AM, Max Beutel notifications@github.com wrote:

Ping – can I get some feedback on this PR? We really would like to get this change upstream. :-)

— Reply to this email directly or view it on GitHub https://github.com/zend-patterns/ZendServerSDK/pull/47#issuecomment-63791128 .

maxbeutel commented 9 years ago

Thanks for merging @slaff and @clarkphp – will one of you guys rebuild the zs-client binary from scratch and commit that? Seems like this was done with previous PRs.

slaff commented 9 years ago

Hi @maxbeutel the zs-client is rebuild and the latest version is already in the repo.