search

zend-patterns / ZendServerSDK

Pure ZF2 CLI for zpk creation and webapi client.
BSD 3-Clause "New" or "Revised" License
22 stars 17 forks source link

Adding directories to scriptsdir.includes #61

Closed ryanheath86 closed 9 years ago

ryanheath86 commented 9 years ago

Scripts directory within the ZPK was not being generated correctly (when directories are added to scriptsdir.includes) for two reasons:

1) The files were contained within a double sub directory : /scripts/scripts 2) Sub-directories of the scripts folder were not being flattened, as is the case when packaging using Zend Studio

Packaging through Zend Studio allows directories to be included in scriptsdir.includes, the behaviour you see there is it copies all the files within that directory, along with all files in any sub-directories, into the scriptsdir defined in the XML - giving you a single directory in the package (named after scriptsdir) which contains all the files, flattened out with no sub-directories.

My update should match this behaviour, but I didnt check adding single files to the scriptsdir.includes as this looked to be handled fine already in the pack() method.

ryanheath86 commented 9 years ago

@boedah New pull request specifically for this issue, as requested by @slaff

slaff commented 9 years ago

I am waiting for documentation from the Zend Studio team about the expected behaviour.

boedah commented 9 years ago

Just referencing #59 into this one...

slaff commented 9 years ago

Refactored the code in this commit f56d829888a58a5d6966c75062cd2ad8d9bea4f0. The suggested change is not longer needed.