search

zendesk / android-floating-action-button

Floating Action Button for Android based on Material Design specification
Apache License 2.0
6.38k stars 1.46k forks source link

Ripple effect on Button #186

Open aritraroy opened 9 years ago

aritraroy commented 9 years ago

Is there a way to add the ripple effect to the buttons? If not, it would be really a very useful enhancement.

Dreamystify commented 9 years ago

+1

AndroidDeveloperLB commented 9 years ago

Yes, I have, and wrote about it here: https://github.com/futuresimple/android-floating-action-button/issues/35

aritraroy commented 9 years ago

@AndroidDeveloperLB Thanks a lot for it. Worked like a charm. But is there any chance of having other errors because of this?

AndroidDeveloperLB commented 9 years ago

@aritraroy Maybe this: https://github.com/futuresimple/android-floating-action-button/issues/175

But I don't remember if it caused an actual crash, or just logs with errors. Also not sure what causes it.

aritraroy commented 9 years ago

Okay thanks. Will let you know if I find any.

AndroidDeveloperLB commented 9 years ago

@aritraroy Thank you. Please also commit the changes to the repo, in case it works well.

aritraroy commented 9 years ago

Will surely do, once I verify it doesn't have any problems.

AndroidDeveloperLB commented 9 years ago

@aritraroy Thank you again. If you wish, you can also check my repos (here: https://github.com/AndroidDeveloperLB?tab=repositories ). You might find some uses for what I did there.

aritraroy commented 9 years ago

Okay surely, I will.

MewX commented 9 years ago

Still hope fab:fab_addButtonColor can set with drawable for custom ripple effects.

droidwithme commented 9 years ago

It did not work for me.@AndroidDeveloperLB

AndroidDeveloperLB commented 9 years ago

@DevendraSingh91 Try this fork I've made: https://github.com/AndroidDeveloperLB/android-floating-action-button