search

zendesk / belvedere

An image picker library for Android
Apache License 2.0
145 stars 23 forks source link

Fix Gradle import in Readme #103

Closed schlan closed 4 years ago

schlan commented 4 years ago

Changes

$subject

Reviewers

@brendan-fahy @baz8080 @schlan @eepDev

References

Risks

bridgeri127 commented 4 years ago

Hi Sebastian

Thank you for the PR, community engagement like this is super important to us and helps keep projects like this alive. In future however would you mind including a brief summary of the contents of your PR in the PR description, under the Changes heading? I see you have entered $summary here so I guess you were trying to insert some kind of dynamic text in here. Unfortunately it doesn't seem to have resolved correctly!

In any case, I think we can proceed with this as is for now. Thanks again for your contribution!

schlan commented 4 years ago

Dear Richard,

I've used the placeholder $subject, not $summary. This imposes a subtle but very important difference: $subject intends to redirect the readers eyes back to the title of the pull request, suggesting the the description in the title is enough to describe the changes made in this merge request.

I'm sorry for any inconveniences caused, Sebastian

brendan-fahy commented 4 years ago

BURN