search

zendesk / belvedere

An image picker library for Android
Apache License 2.0
145 stars 23 forks source link

Migrate to AndroidX and remove all dependency on old support lib #109

Closed magnusvs closed 4 years ago

magnusvs commented 4 years ago

I've migrated Belvedere to use AndroidX because some Zendesk SDKs seems to rely on this library and I think it is the last reference to the old support-libraries I have in my app. It would be nice if Belvedere could merge this and release a new version that the Zendesk SDKs could use now that they seem to have migrated to AndroidX as well.

Changes

Migrated all references from android.support. to androidX. Some minor changes because of changes in AndroidX libraries. Uses Material Components for some UI components. Replace Picasso Compat with Picasso 2.8 because this version is uses AndroidX. Update Gradle version & Android Gradle build tools.

Reviewers

@brendan-fahy @baz8080 @schlan @eepDev

References

Migrating to AndroidX Picasso 2.8 Material Components

Risks

This is a breaking change for apps still not using AndroidX. Maybe consider bumping the major version code with the release of this version. Also it's using a new version of Picasso directly instead of the Picasso Compat library.

baz8080 commented 4 years ago

Hi Magnus. It's close to the end of the day here but I'll check it out tomorrow, thanks!