search

zendesk / cross-storage

Cross domain local storage, with permissions
Apache License 2.0
2.22k stars 180 forks source link

Removed named module as this causes portability issues when using r.js #18

Closed pixeldrew closed 9 years ago

pixeldrew commented 9 years ago

Require-config should specify location and name of module by filename

This allows you to use path config to specify directory and name is defined by filename for example define(['cross-storage/hub'], function(hub){ ... }); define(['cross-storage/client'], function(client){ ... });

Otherwise you have to make path config entries for each file, this is also more inline with commonjs naming conventions

pixeldrew commented 9 years ago

I didn't commit the dist files as I expect you would probably want to version bump and commit them yourself. (if you accept this PR)

danielstjules commented 9 years ago

Thanks for the PR! :) Makes sense to let the module id be derived by file path/name.