search

zendesk / cross-storage

Cross domain local storage, with permissions
Apache License 2.0
2.22k stars 180 forks source link

Main file as client.js #33

Closed JasonLi914 closed 7 years ago

JasonLi914 commented 7 years ago

Would it be possible to set the main file as client.js? Currently running into issues on our suite of projects that use Wiredep that are unable to load it in without setting an override for the main file in our bower.json's.

danielstjules commented 7 years ago

Would this be fixed by updating the project's bower.json to include:

  "main": [
    "./dist/client.min.js",
    "./dist/hub.min.js"
  ]
JasonLi914 commented 7 years ago

Yes, that should fix it I believe

JasonLi914 commented 7 years ago

Actually, sorry, I don't think that's exactly what we want. Including both as the main would bring in both files all the time, when we would only ever want one or the other. Originally I said client.js because it is in more cases likely to be the desired one, and then an override can be used for the smaller number of cases where hub.js is desired. However, I can understand if this is not feasible, and if that's the case, I was wondering if the hub and client could be separate projects, where the main file is the respective and correct file? Please let me know your thoughts on this, thank you!

danielstjules commented 7 years ago

Closing due to inactivity. I think this issue could be resolved through configuration of Wiredep.