Add storage opt in hub. Can now configure localStorage or sessionStorage - Githubissues

zendesk / cross-storage

Cross domain local storage, with permissions

Apache License 2.0

2.22k stars 180 forks source link

Add storage opt in hub. Can now configure localStorage or sessionStorage #54

Open cyrilchapon opened 6 years ago

cyrilchapon commented 6 years ago

Hello.

I made this because we needed support for sessionStorage option.

Changes :

Hub() constructor now accepts a single opts arguments
- opts.permissions behaves like previously permissions
- opts.storage is added. Can be one of window.localStorage and window.sessionStorage (or any object with the same API, I guess). It defaults to window.localStorage

Compat checks with window.localStorage are now made to opts.storage

TODO : Some tests should be added to ensure

Chosen storage is respected
Unprovided storage defaults to localStorage
Everything works like excepted