zendesk / cross-storage

Cross domain local storage, with permissions
Apache License 2.0
2.22k stars 180 forks source link

Zuul test report an error for "del" #55

Closed cyrilchapon closed 6 years ago

cyrilchapon commented 6 years ago

I'm getting this :

capture d ecran 2018-10-10 a 10 26 14

This seems to be because of beforeEach hook here which does :

    beforeEach(function(done) {
      cleanup(done);
    });

    var cleanup = function(fn) {
      storage.onConnect().then(function() {
        return storage.del('key1', 'key2');
      })
      .then(fn)
      ['catch'](fn);
    };

But in this test-case, storage doesn't have permission to delete.

cyrilchapon commented 6 years ago

Sorry this was created by https://github.com/zendesk/cross-storage/pull/54

I fixed it in the PR.