helm_wrapper does a verbose rm for cleanup interfering with templating

zendesk / helm-secrets

DEPRECATED A helm plugin that help manage secrets with Git workflow and store them anywhere

Apache License 2.0

1.16k stars 155 forks source link

helm_wrapper does a verbose rm for cleanup interfering with templating #126

Open ilionblaze opened 5 years ago

ilionblaze commented 5 years ago

Due to the verbose flag in the cleanup code for helm_wrapper, decrypted filenames are output:

    # cleanup on-the-fly decrypted files
    [[ ${#decfiles[@]} -gt 0 ]] && rm -v "${decfiles[@]}"

This means you can't run helm secrets template -f values.yaml -f secrets.yaml ./ > template.yaml without having to edit the file.

Removing the -v would fix this, or adding a new flag to run a silent cleanup. I suspect the goal is to avoid new flags which may interfere with helm compatibility?

kavirajk commented 5 years ago

really block from using tools like Tilt (tilt.dev). Where we generate k8 specs via helm-template.