zendesk / helm-secrets

DEPRECATED A helm plugin that help manage secrets with Git workflow and store them anywhere
Apache License 2.0
1.16k stars 155 forks source link

"Not encrypted" line causing trouble in Spinnaker pipeline #144

Open gjgarryuan opened 4 years ago

gjgarryuan commented 4 years ago

https://github.com/futuresimple/helm-secrets/blob/5f91bdfc66bd901e3088aac2efa2d107a055ea39/secrets.sh#L303

I am using helm secrets template command to render the helm chart and upload to S3 for later Spinnaker pipeline deployment uses.

However, if the command is used with a template secrets file not encrypted (due to no secrets at all but just serve as a place holder), the resulting yaml file will always contain the Not encrypted: as the first line, which the Spinnaker pipeline doesn't like and fail the pipeline with this error:

Exception ( Deploy Manifest )
Missing required field 'kind' on manifest: {Not encrypted=helm/deployments/some-tenant/staging/secrets.yaml}

It will be very convenient if the plugin can expose an option which tells the secret plugin to not generate that Not encrypted: line, or make that line into a comment.