upgrade doesn't expose underlying helm return code

[farrellit]

if, say, I invoke helm improperly ( this case I'm omitting the -f secrets.yaml that pull in the secret values), I get this error, and exit code 1;

$ helm upgrade --install ci-develop --namespace ci -f values.yaml .
Release "ci-develop" does not exist. Installing it now.
Error: render error in "dod/templates/dod_secrets.yml": template: dod/templates/dod_secrets.yml:13:54: executing "dod/templates/dod_secrets.yml" at <b64enc>: invalid value; expected string
$ echo $?
1

As it should be. But when I run with helm secrets, the same error is generated ,but the exit code becomes 0.

$ helm secrets upgrade --install ci-develop --namespace ci -f values.yaml .
Release "ci-develop" does not exist. Installing it now.
echo $?
Error: render error in "dod/templates/dod_secrets.yml": template: dod/templates/dod_secrets.yml:13:54: executing "dod/templates/dod_secrets.yml" at <b64enc>: invalid value; expected string
danfarrell@mac 2018.12.12 16:50:58 develop ~/git/k8s_dev/dod
$ echo $?
0

This completely breaks my CI/CD process, and I think it would break any CI/CD process which needs to fail if helm doesn't work.

I think it's because we exit 0 at the end of the secrets.sh script so I'll throw a PR out to exit with the helm code instead and see what folks think.

[ayk33]

Any updates on this?

[farrellit]

There seems to be a disturbing lack of support for this repo, for something that is apparently "production ready". Does the community have to fork this?

[ayk33]

My issue is the PR is waiting for approval right now. Anyway we can get this resolved quickly?

[yardik]

Seems to be abandoned - been 3 months since the author contributed to anything on github,

[ayk33]

@ckannon any idea if there has been a fork of this repo?

[ChrisCooney]

Would be good to get somewhere with this!

[farrellit]

Awesome to see this merged in!