search

zendesk / laika

Log, test, intercept and modify Apollo Client's operations
https://zendesk.github.io/laika
Apache License 2.0
122 stars 7 forks source link

Remove dependency on React #11

Closed Mando75 closed 2 years ago

Mando75 commented 2 years ago

Hi,

I am currently evaluating using Laika in our Vue/Nuxt application. As it stands, Laika has a transitive dependency on React via @apollo/client. I see you currently have this solved by including React as a dev dependency. However, this causes problems when trying to use Laika in a non-React application.

When we try to initialize the Laika link, we get a build error since Apollo cannot find the React dependency anywhere (See this GitHub issue for reference https://github.com/apollographql/apollo-client/issues/8958). The solution to this would be to update the imports within Laika to use @apollo/client/core instead of @apollo/client (see this portion of the Apollo docs). This would also allow you to remove React dev dependency from Laika.

I have already forked Laika and made the required changes in a separate branch so I can continue my work, but I wanted to raise an issue as this may limit Laika's viability for non-React projects. I am more than happy to open that branch as a PR here if you would like to review the changes I made and potentially merge them into the main project.

Mando75 commented 2 years ago

I went ahead and opened a PR to address this. See #14