zendesk / prop

Puts a cork in their requests
Apache License 2.0
120 stars 13 forks source link

Using the leaky bucket strategy, how to cap the value of the counter? #31

Open acrispino opened 6 years ago

ctuong commented 5 years ago

Are you referring to the fact that the counter continues to be incremented in the cache even if the burst_rate has already been exceeded? If so, I agree that the counter should only be incremented in the cache if the counter + increment_value does not exceed the burst_rate, otherwise it should just return true (for throttled?).