search

zendesk / react-native-sunshine-conversations

React Native wrapper for Smooch.io
MIT License
36 stars 26 forks source link

Add activity flag to native SDK #12

Closed avishayil closed 7 years ago

avishayil commented 8 years ago

Hi,

I made a fork of the library and made it easier and more "standard" method to import the smooch library, by making the android files and iOS files to libraries, then linking with RNPM should be easier, importing is easier, etc.

Fork is here: https://github.com/avishayil/react-native-smooch

The only problem i'm encountering is on Android is that the intent is not launching when calling the show() method, because the show method of ConversationActivity cannot launch without the FLAG_ACTIVITY_NEW_TASK flag.

Do you think you'd be able to incorporate the support in your SDK?

After it's done i'll be able to pull request the module.

Thanks!

Avishay.

alavers commented 8 years ago

Appreciate the work @avishayil !

@jugarrit what do you think?

jugarrit commented 8 years ago

There is a second show method which allows you to supply flags.

I'd be happy to take a look at the pull request once it's opened!

Thanks :)

avishayil commented 8 years ago

Working great, thanks! It's complete. I'll pull request, but don't have time for now to update the Readme files with all the images and instructions. Mind helping me doing it?

dgilliam commented 7 years ago

any update on this?

jugarrit commented 7 years ago

@dgilliam I'll be looking at this in the coming weeks.

jugarrit commented 7 years ago

Merged #13