zendesk / react-native-sunshine-conversations

React Native wrapper for Smooch.io
MIT License
36 stars 26 forks source link

Updated README for Android #2

Closed polacekpavel closed 8 years ago

polacekpavel commented 8 years ago

I was able to run Smooch module in react native with these changes.

Mario54 commented 8 years ago

Hey, @polacekpavel!

Thanks for adding clarifications to the README.

I have one concern regarding the instructions for the AndroidManifest.xml file, they shouldn't be necessary when using Android Studio. It should only be necessary to add configuration to the manifest when adding push notifications, in which case we should link to http://docs.smooch.io/android/#configuring-push-notifications for the instructions.

Were you using Android Studio or another IDE?

jugarrit commented 8 years ago

Closing this because instructions have changes somewhat and section added to the AndroidManifest.xml is not needed.