rm react-native dependency from package.json

zendesk / react-native-sunshine-conversations

React Native wrapper for Smooch.io

MIT License

36 stars 26 forks source link

rm react-native dependency from package.json #20

Closed johnstonmatt closed 7 years ago

johnstonmatt commented 7 years ago

I don't think you are suppose to include react-native as a dependency, try importing it from the project that is using this module

norman-kapschefsky commented 7 years ago

+1 I think you are right. I got a lot of duplicate errors when starting npm like:

Error: @providesModule naming collision:
  Duplicate module name: react-native-vector-icons
  Paths: .../MyApp/node_modules/react-native/local-cli/core/__fixtures__/files/package.json collides with .../MyApp/node_modules/react-native-smooch/node_modules/react-native/local-cli/core/__fixtures__/files/package.json