zendesk / react-native-sunshine-conversations

React Native wrapper for Smooch.io
MIT License
36 stars 26 forks source link

Not building when use_frameworks! is set #24

Closed FrankSalad closed 6 years ago

FrankSalad commented 7 years ago

Build fails inside RCTSmooch library when use_frameworks! is set in the Podfile.

Lexical or preprocessor issue:
'Smooch.Smooch.h' file not found
Showing All Messages
CompileC /Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Intermediates/RCTSmooch.build/Debug-iphonesimulator/RCTSmooch.build/Objects-normal/x86_64/RCTSmooch.o RCTSmooch/RCTSmooch.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
    cd $PROJECT_ROOT/node_modules/react-native-smooch/ios
    export LANG=en_US.US-ASCII
    export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu99 -fobjc-arc -fmodules -fmodules-cache-path=/Users/user/Library/Developer/Xcode/DerivedData/ModuleCache -fmodules-prune-interval=86400 -fmodules-prune-after=345600 -fbuild-session-file=/Users/user/Library/Developer/Xcode/DerivedData/ModuleCache/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror=non-modular-include-in-framework-module -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wunreachable-code -Wno-implicit-atomic-properties -Werror=deprecated-objc-isa-usage -Werror=objc-root-class -Wno-arc-repeated-use-of-weak -Wduplicate-method-match -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wundeclared-selector -Wno-deprecated-implementations -DDEBUG=1 -DOBJC_OLD_DISPATCH_PROTOTYPES=0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator10.3.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -mios-simulator-version-min=7.0 -g -Wno-sign-conversion -Wno-infinite-recursion -fobjc-abi-version=2 -fobjc-legacy-dispatch -iquote /Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Intermediates/RCTSmooch.build/Debug-iphonesimulator/RCTSmooch.build/RCTSmooch-generated-files.hmap -I/Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Intermediates/RCTSmooch.build/Debug-iphonesimulator/RCTSmooch.build/RCTSmooch-own-target-headers.hmap -I/Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Intermediates/RCTSmooch.build/Debug-iphonesimulator/RCTSmooch.build/RCTSmooch-all-non-framework-target-headers.hmap -ivfsoverlay /Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Intermediates/RCTSmooch.build/all-product-headers.yaml -iquote /Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Intermediates/RCTSmooch.build/Debug-iphonesimulator/RCTSmooch.build/RCTSmooch-project-headers.hmap -I/Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Products/Debug-iphonesimulator/include -I/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include -I../../react-native/React -I../../react-native/React/Base -I../../react-native/React/CxxBridge -I../../react-native/React/CxxModule -I../../react-native/React/CxxUtils -I../../react-native/React/DevSupport -I../../react-native/React/Executors -I../../react-native/React/Modules -I../../react-native/React/Profiler -I../../react-native/React/Views -I$PROJECT_ROOT/node_modules/react-native-smooch/ios/../../../ios/Pods/Headers/Public/Smooch -I$PROJECT_ROOT/node_modules/react-native-smooch/ios/../../../ios/Pods/Headers/Public -I/Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Intermediates/RCTSmooch.build/Debug-iphonesimulator/RCTSmooch.build/DerivedSources/x86_64 -I/Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Intermediates/RCTSmooch.build/Debug-iphonesimulator/RCTSmooch.build/DerivedSources -F/Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Products/Debug-iphonesimulator -MMD -MT dependencies -MF /Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Intermediates/RCTSmooch.build/Debug-iphonesimulator/RCTSmooch.build/Objects-normal/x86_64/RCTSmooch.d --serialize-diagnostics /Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Intermediates/RCTSmooch.build/Debug-iphonesimulator/RCTSmooch.build/Objects-normal/x86_64/RCTSmooch.dia -c $PROJECT_ROOT/node_modules/react-native-smooch/ios/RCTSmooch/RCTSmooch.m -o /Users/user/Library/Developer/Xcode/DerivedData/ExampleProject-etnqmzxsdqgipxegtajlasydqjww/Build/Intermediates/RCTSmooch.build/Debug-iphonesimulator/RCTSmooch.build/Objects-normal/x86_64/RCTSmooch.o

$PROJECT_ROOT/node_modules/react-native-smooch/ios/RCTSmooch/RCTSmooch.m:2:9: fatal error: 'Smooch/Smooch.h' file not found
#import <Smooch/Smooch.h>
        ^
1 error generated.
FrankSalad commented 7 years ago
screen shot 2017-06-11 at 9 35 38 pm
gozman commented 7 years ago

Thanks for the PR @FrankSalad I've merged it in but haven't repro'd myself.