zendesk / react-native-sunshine-conversations

React Native wrapper for Smooch.io
MIT License
36 stars 26 forks source link

Fix Maven repo typo #43

Closed BigGillyStyle closed 6 years ago

BigGillyStyle commented 6 years ago

Just a small typo in the Maven URL

jugarrit commented 6 years ago

Oops 🙈 I suppose that reference mustn't be that important if the project still builds with the typo. Would you be able to remove it entirely and verify if it's still working?

BigGillyStyle commented 6 years ago

In my own React Native that uses this library I had to make the following changes in order to circumvent this problem:

[my RN app]/android/build.gradle

BEFORE

allprojects {
    repositories {
        mavenLocal()
        jcenter()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../node_modules/react-native/android"
        }
    }
}

AFTER

allprojects {
    repositories {
        mavenLocal()
        jcenter()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../node_modules/react-native/android"
        }
        maven {
            url 'https://maven.google.com'
        }
    }
}
shahidjabbar commented 6 years ago

@BigGillyStyle Big thanks! It is possible that you were able to build due to cached m2, @jugarrit. But if you start with a clean react-native init smoochtest and add react-native-smooch on top of it, it will fail.

BigGillyStyle commented 6 years ago

Just a note...I'm no longer with the company that provided me with the project to work with this package, so unfortunately I won't be able to provide any updates on this issue. Feel free to close it.

jugarrit commented 6 years ago

I will fix this in the next release, thanks for reporting!