search

zendesk / react-native-sunshine-conversations

React Native wrapper for Smooch.io
MIT License
36 stars 26 forks source link

Add podspec #9

Closed adbl closed 8 years ago

adbl commented 8 years ago

Removes the need to install/link 'Smooch' pod separately when using CocoaPods.

alavers commented 8 years ago

Thanks for the PR!

adbl commented 8 years ago

Cool, fixed the comments!

alavers commented 8 years ago

Hmm, another issue with this approach is that the react-native-smooch Pod target includes the ios/SmoochManager.h and .m files, so when you build you get an error: RCTBridgeModule.h file not found

Is there a simple way to fix that?

adbl commented 8 years ago

Oh, i'm not seeing that... In our Podfile we have the following:

pod 'React', :subspecs => [
      'Core',
      'RCTImage',
      'RCTNetwork',
      'RCTPushNotification',
      'RCTText',
      // ...
    ], :path => '../node_modules/react-native'

Having this is assumed, there are some references to this in the official docs: http://facebook.github.io/react-native/releases/0.31/docs/troubleshooting.html#missing-libraries-for-react http://facebook.github.io/react-native/releases/0.31/docs/integration-with-existing-apps.html#react-native-framework but it doesn't hurt to add some note about it I guess.

I think we might want to keep something like this in the podspec too, which I saw in another podspec: s.dependency 'React/Core'

alavers commented 8 years ago

Yeah the Podfile react requirements should be mentioned, but I can take care of that. Thanks again!