search

zendesk / samlr

Clean room implementation of SAML for Ruby
Apache License 2.0
30 stars 12 forks source link

mutiple attribute values not mapped correctly. #1

Closed lstanden closed 11 years ago

lstanden commented 11 years ago

I'm encountering an issue where multiple attributeValue nodes are not mapped correctly. This is particularly relevant when it comes to memberOf group memberships being returned via the SAML response.

Here's an example snippet of XML:

<saml:Attribute Name="memberOf" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:basic">
  <saml:AttributeValue xsi:type="xs:string">cn=example1,ou=groups,ou=somegroup,o=example</saml:AttributeValue>
  <saml:AttributeValue xsi:type="xs:string">cn=example2,ou=groups,ou=somegroup,o=example</saml:AttributeValue>
  <saml:AttributeValue xsi:type="xs:string">cn=example3,ou=groups,ou=somegroup,o=example</saml:AttributeValue>
  <saml:AttributeValue xsi:type="xs:string">cn=example4,ou=groups,ou=somegroup,o=example</saml:AttributeValue>
  <saml:AttributeValue xsi:type="xs:string">cn=example5,ou=groups,ou=somegroup,o=example</saml:AttributeValue>
  <saml:AttributeValue xsi:type="xs:string">cn=example6,ou=groups,ou=somegroup,o=example</saml:AttributeValue>
  <saml:AttributeValue xsi:type="xs:string">cn=example7,ou=groups,ou=somegroup,o=example</saml:AttributeValue>
  <saml:AttributeValue xsi:type="xs:string">cn=example8,ou=groups,ou=somegroup,o=example</saml:AttributeValue>
  <saml:AttributeValue xsi:type="xs:string">cn=example9,ou=groups,ou=somegroup,o=example</saml:AttributeValue>
  <saml:AttributeValue xsi:type="xs:string">cn=example10,ou=groups,ou=somegroup,o=example</saml:AttributeValue>
</saml:Attribute>
morten commented 11 years ago

Released v0.2.5 which should fix this. You will get an array of values in the above case. Thanks for the heads up.