search

zendesk / samlr

Clean room implementation of SAML for Ruby
Apache License 2.0
30 stars 12 forks source link

[WIP] Support for logout options #12

Closed anamartinez closed 10 years ago

anamartinez commented 10 years ago

@steved555 thoughts?

anamartinez commented 10 years ago

bump @steved555 I moved the options under name_id_options. Since name_id is mandatory I wasn't sure if you wanted to make that hash something like:

:name_id =>  { 
  :id => name_id,
  :name_qualifier => "asd",
  :spname_qualifier => "asdf"
}

Let me know if you prefer the above. Also this is a breaking change (since we are moving format into a hash, so I'm unsure on how you want to handle this.

steved commented 10 years ago

Nah, this is fine. Let's just support :name_id_format for a while, but spit out a deprecation warning. We can remove it if we ever go v3.

anamartinez commented 10 years ago

@steved555 last review? I also added test.

steved commented 10 years ago

:+1: