doctype definitions cause XML parsing problems in JRuby - Githubissues

zendesk / samlr

Clean room implementation of SAML for Ruby

Apache License 2.0

30 stars 12 forks source link

doctype definitions cause XML parsing problems in JRuby #2

Open lstanden opened 11 years ago

lstanden commented 11 years ago

It appears the doctype definitions at the top of the following files cause XML validation errors in JRuby:

xmldsig-core-schema.xsd

morten commented 11 years ago

Do you have some sort of stack trace or similar that I can go with? Tests are passing on JRuby on Travis - I'd hope a W3C XML file to be valid.

morten commented 11 years ago

That was wrong. I don't remember why I'm not testing JRuby but am investigating.

lstanden commented 11 years ago

Awesome... I intended to put some more information in there last night, but didn't end up having time to look at it.

I found when I removed the doctype definitions from two different files that I was able to get further, but then it appears I ran into another issue where the SHA checksums didn't match.

morten commented 11 years ago

I may have fixed the SHA checksums - at least I just pushed a fix because they were failing under different rubies. Still trying to wrap my head around the underlying issue for this one.

morten commented 11 years ago

Removing the DOCTYPEs still surfaces other issues. Looks like severe problems with XML canonicalization in the Nokogiri Java parts.

morten commented 11 years ago

I've reported the c14n issue with Nokogiri https://github.com/sparklemotion/nokogiri/issues/808 Judging from the size of their issues queue I'm afraid theres not much hope for a short term fix